Fix xmlns emission for unqualified schemas and make it prefix-dependent#261
Merged
Bergmann89 merged 2 commits intomasterfrom Mar 26, 2026
Merged
Fix xmlns emission for unqualified schemas and make it prefix-dependent#261Bergmann89 merged 2 commits intomasterfrom
xmlns emission for unqualified schemas and make it prefix-dependent#261Bergmann89 merged 2 commits intomasterfrom
Conversation
When using some of the helper methods to add render steps to the config, some of the steps were added twice. This commit fixes that by ensuring that the helper methods only add the render step if it hasn't been added already.
Emit suitable namespace declarations (xmlns) on the root element for schemas with unqualified elements. In XSD, global elements are always namespace-qualified regardless of elementFormDefault, so the root element must declare its namespace even when local elements are unqualified. Additionally, make the emitted xmlns prefix depend on the tag name passed to the serializer at runtime. If the name contains a prefix (e.g. "tns:Element"), the declaration uses that prefix (xmlns:tns="..."); otherwise it emits the default namespace (xmlns="...").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #256